Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deps to core #1586

Merged
merged 11 commits into from
Sep 12, 2023
Merged

Remove deps to core #1586

merged 11 commits into from
Sep 12, 2023

Conversation

JasonMarechal25
Copy link
Contributor

  • Remove dependencies in libantarescore, now in study
  • Remove several dependencies to libantarescore
  • Don't remove dependency to libantarescore in UI

@flomnes
Copy link
Member

flomnes commented Aug 28, 2023

There seems to be a missing dependency to Boost. Build fails on Windows

D:\a\Antares_Simulator\Antares_Simulator\src\libs\antares\study\parts\common\cluster_list.cpp(1,10): fatal  error C1083: Cannot open include file: 'boost/algorithm/string/case_conv.hpp': No such file or directory [D:\a\Antares_Simulator\Antares_Simulator\_build\libs\antares\study\study.vcxproj]

@JasonMarechal25
Merge remote-tracking branch 'origin/develop' into feature/core-deps
0c87ecb 
# Conflicts:
#	src/analyzer/CMakeLists.txt
#	src/libs/antares/CMakeLists.txt
#	src/libs/antares/InfoCollection/CMakeLists.txt
#	src/libs/antares/benchmarking/DurationCollector.cpp
#	src/libs/antares/correlation/CMakeLists.txt
#	src/libs/antares/memory/CMakeLists.txt
#	src/libs/antares/sys/CMakeLists.txt
#	src/solver/CMakeLists.txt
#	src/solver/main/CMakeLists.txt
#	src/solver/simulation/CMakeLists.txt
#	src/tools/cleaner/CMakeLists.txt
#	src/tools/config/CMakeLists.txt
#	src/tools/kirchhoff-cbuilder/main.cpp
#	src/tools/updater/CMakeLists.txt
#	src/tools/yby-aggregator/CMakeLists.txt
#	src/ui/simulator/CMakeLists.txt
#	src/ui/simulator/application/main/create.cpp
#	src/ui/simulator/cmake/application.cmake
@JasonMarechal25
Fix merge
cce0af8
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@flomnes flomnes merged commit 40e4383 into feature/study Sep 12, 2023
@flomnes flomnes deleted the feature/core-deps branch September 12, 2023 09:23
flomnes pushed a commit that referenced this pull request Sep 12, 2023
@JasonMarechal25 @JasonMarechal
Split study in CMakefile (#1583)
b6d0993 
* Move writer in libs

* wip

* Benchmarking

* Remove extra dependency

* Move writer in libs

* Fix post rebase

* Remove Yuni target include

* Lots of lib change

* Lots of lib change

* Remove extra writer dependency

* Improve Cmake correlation

* Improve Cmake checks

* Improve Cmake benchmarking

* Improve Cmake array

* Improve Cmake exception

* Improve Cmake inifile

* Improve Cmake io

* Improve Cmake jit

* Improve Cmake logs

* Fix date cmake

* Fix compil for logs

* Sys wip

* Memory wip

* Finish Memory/sys

* Fix post merge

* Remove extra include

* Fix include

* Remove sys as direct dependency of antares-core (#1561)

* Remove memory usage

* Fix merge

* Remove extra dependency

* Move public dependency as private

* Remove deprecated dependency

* Split Duration collector and StudyInfoCollector

* Move OptimizationInfo in proper place

* Split SimulationInfoCollection from Benchmarking

* Split study in CMakefile

* Fix merge

* Remove lots of libs from core

* Remove dependency to libantares-core

* Fix boost compil

* Fix boost compil

* Fix hostname/policy link error

* Add missing link to thermal definition

* Make yuni public in lib-matrix for test

* Loosen build parallelization

* Try fix

* Remove extra include to log causing link error

* Fix windows compilation: missing link to winsock

* Fix UI compilation

* Revert removing -j options during CI

* Remove deps to core (#1586)

* Fix merge

* Fix compil

* Fix compil

* Reestablish -j2 build option as it doesn't change anything removing it

* Remove commented code

* Use proper casing for s(S)ettings struct

* Remove duplicated link dependency

* add missing dependency in writer

---------

Co-authored-by: Jason Marechal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flomnes flomnes flomnes approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JasonMarechal25 @flomnes